-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: update cperf Kingfisher entry to try and fix build #965
Conversation
@swift-ci test |
failures appear to be from
@justice-adams-apple thank you for running CI for this. as neither of the failures seem related to the change i'm hoping to land, what are the recommended next steps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamieQ Correct, these failures are not related to your PR 😄
swiftlang/swift#78870
This LGTM.
I'll merge this is as soon as I'm able to, in the next few days. (don't have force merge permissions currently) |
@justice-adams-apple can we do cross-repo testing with source compatibility PRs? We could give this a try with |
@swift-ci please test |
@xedin @justice-adams-apple i see this passed CI – thanks for resolving that. if this seems alright, would one of you mind merging this when you get a chance please? |
Thank you, @jamieQ ! |
Pull Request Description
aims to resolve swiftlang/swift#78654