Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: update cperf Kingfisher entry to try and fix build #965

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Jan 16, 2025

Pull Request Description

  • updates the Kingfisher entry in the cperf configuration to try and fix the compiler performance smoketests
  • the existing prior commit for this project appears to not exist in the project

aims to resolve swiftlang/swift#78654

@justice-adams-apple
Copy link
Contributor

@swift-ci test

@jamieQ
Copy link
Contributor Author

jamieQ commented Jan 22, 2025

failures appear to be from vapor_jwt and vapor_jwt-kit. both seem to be from some issue dealing with CoreFoundation (failing to synthesize a Hashable conformance for CFString):

error: compile command failed due to signal 6 (use -v to see invocation)
<unknown>:0: note: automatic synthesis of 'Hashable' is not supported for class declarations
SIL verification failed: method does not appear in the class's vtable: VerifyClassMethodVisitor(member).Seen || operandType.isForeignReferenceType()
Verifying instruction:
     %1 = load_borrow %0 : $*CFString             // users: %4, %3, %2
->   %2 = class_method %1 : $CFString, #CFString.hashValue!getter : (CFString) -> () -> Int, $@convention(method) (@guaranteed CFString) -> Int // user: %3
     %3 = apply %2(%1) : $@convention(method) (@guaranteed CFString) -> Int // user: %5
In function:
// protocol witness for Hashable.hashValue.getter in conformance CFStringRef
sil shared [transparent] [serialized] [thunk] [ossa] @$sSo11CFStringRefaSHSCSH9hashValueSivgTW : $@convention(witness_method: Hashable) (@in_guaranteed CFString) -> Int {
// %0                                             // user: %1
bb0(%0 : $*CFString):
  %1 = load_borrow %0                             // users: %4, %3, %2
  %2 = class_method %1, #CFString.hashValue!getter : (CFString) -> () -> Int, $@convention(method) (@guaranteed CFString) -> Int // user: %3
  %3 = apply %2(%1) : $@convention(method) (@guaranteed CFString) -> Int // user: %5
  end_borrow %1                                   // id: %4
  return %3                                       // id: %5
} // end sil function '$sSo11CFStringRefaSHSCSH9hashValueSivgTW'

Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.

@justice-adams-apple thank you for running CI for this. as neither of the failures seem related to the change i'm hoping to land, what are the recommended next steps?

Copy link
Contributor

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamieQ Correct, these failures are not related to your PR 😄
swiftlang/swift#78870

This LGTM.

@justice-adams-apple
Copy link
Contributor

I'll merge this is as soon as I'm able to, in the next few days. (don't have force merge permissions currently)

@xedin
Copy link
Contributor

xedin commented Jan 24, 2025

@justice-adams-apple can we do cross-repo testing with source compatibility PRs? We could give this a try with please smoke test compiler performance if cross-repo with source compatibility PRs works.

@xedin
Copy link
Contributor

xedin commented Jan 25, 2025

@swift-ci please test

@jamieQ
Copy link
Contributor Author

jamieQ commented Jan 26, 2025

@xedin @justice-adams-apple i see this passed CI – thanks for resolving that. if this seems alright, would one of you mind merging this when you get a chance please?

@xedin xedin merged commit 7e15bbc into swiftlang:main Jan 27, 2025
1 check passed
@xedin
Copy link
Contributor

xedin commented Jan 27, 2025

Thank you, @jamieQ !

@jamieQ jamieQ deleted the ci-fix-attempt branch January 27, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler performance smoke tests are currently broken
3 participants