Have the Contributor Experience Workgroup code-own the respective page #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
AnthonyLatsis
commented
Sep 10, 2024
Comment on lines
+30
to
+37
| # | ||
| # Lines starting with '#' are comments. | ||
| # Each line is a case-sensitive file pattern followed by one or more owners. | ||
| # Order is important — the last matching pattern has the most precedence. | ||
| # More information: https://docs.github.com/en/articles/about-code-owners | ||
| # | ||
| # Please mirror the repository's file hierarchy in case-sensitive lexicographic | ||
| # order. |
There was a problem hiding this comment.
I borrowed this header from swift.
There was a problem hiding this comment.
When I looked at this PR through GitHub's web interface, it's complaining there's an error in the file:
Unknown owner on line 43: make sure the team @swiftlang/contributor-experience exists, is publicly visible, and has write access to the repository
There was a problem hiding this comment.
Yeah. Makes sense though — an entity needs write access to own something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This change is not so much about claiming ownership as getting the workgroup automatically and specially notified about changes to this area and encourage review. I have specified our team as the only owner for now, but I am happy to add more people should it be desired.
cc @swiftlang/contributor-experience
We may also want to (co-)own mentorship stuff for the same reason.