Improve page metadata for sharing #274
Conversation
- In _config.yml file: - Enable page excerpts - Set excerpt separator - In base layout: - Calculate title, description, URL in one place for meta tags - Always use page values for meta tags when present, fallback to site values - Replace conditional tags with single tag that uses calculated value - Move robots meta tag out from the middle of Open Graph tags - Reduce excessive whitespace from generated newlines - Add explicit excerpts to front matter of pages where automatic excerpt was not suitable / sufficient - Small adjustments to page first paragraphs to generate better description meta tags - Resolves swiftlang#203
dempseyatgithub
requested review from
0xTim,
alexandersandberg,
daveverwer,
kaishin,
krstnfx,
mschinis,
shahmishal,
TimTr,
twostraws and
tomerd
as code owners
|
@swift-ci test |
|
I just found an unexpected issue with this PR. It causes all the posts on the main blog page to render full text instead of excerpts. I won't have time today to track down the cause, but will turn this back into a full PR once I address that issue. |
|
I have spent some time investigating the issue. There seems to be a bug in Jekyll where turning on page excerpts causes each post on the blog page to display its full text and not its excerpt. I tested with the latest version of Jekyll and still see this issue. I also have found the issue to be nondeterministic. Sometimes I can enable page excerpts without the bug occurring, sometimes it seems adding a call into the page excerpt for the meta tags causes it to happen. However, backing out the changes does not always revert the behavior. I haven't found a similar issue mentioned searching in Jekyll forums. My next step would be to try to reproduce the issue in a simple Jekyll project. |
This PR addresses the issues in Issue #203: