Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebURL Proposal #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WebURL Proposal #66

wants to merge 1 commit into from

Conversation

karwa
Copy link

@karwa karwa commented Mar 30, 2022

WDYT?

@karwa karwa changed the title Add WebURL WebURL Proposal Mar 30, 2022
tayloraswift
tayloraswift reviewed Mar 30, 2022
View reviewed changes
proposals/xxxx-weburl.md
- It has modern **standards support**, bringing web-compatible URL processing to Swift for the first time,
and matching browsers and more libraries in other languages.

- Its API is truly **designed for Swift**, and leverages the language to great effect: the `Host` enum gives you greater
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the most important paragraph, and should be moved to the front. in fact, i think the summary should come first…

@0xTim
Copy link
Member

0xTim commented Mar 31, 2022

@karwa just an FYI - we (the SSWG) have seen this and are in the process of getting it through the review pipeline

@karwa
Copy link
Author

karwa commented Mar 31, 2022

Awesome, thanks @0xTim !

@FranzBusch
Copy link
Contributor

Hey Karl,
Thanks for being so patient with this. We really appreciate all the effort you put into this package and we do agree that we need a type in the ecosystem that implements the WHATWG semantics. Since you pitched your package for incubation, a lot has happened in the ecosystem such as the new swift-foundation initiative. Have you considered about adding this to Foundation's URL type instead. This would give it a much broader impact and audience. While swift-foundation is still ramping up right now the README already states that URL is going to be part of the new implementation. Furthermore, swift-foundation follows a similar evolution process as the Swift language and it would be a great step to write a proposal how the WHATWG semantics can be added to URL without breaking API or ABI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tayloraswift tayloraswift tayloraswift left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karwa @0xTim @FranzBusch @tayloraswift