Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mandatory and suggested copy-edits #51

Closed
wants to merge 9 commits into from

Conversation

robbiemorrison
Copy link
Contributor

mandatory copy-edits — with all further PRs optional:

  • missing colon added
  • "FOSS" abbreviation replaced

@robbiemorrison
Copy link
Contributor Author

I wonder if the date range of "2020–2023" is required on the license notice. I did not remove it. But I understand that current advice is that this is not necessary and generally best avoided? Consult a lawyer perhaps!

@robbiemorrison
Copy link
Contributor Author

these diffs are optional

@robbiemorrison
Copy link
Contributor Author

Note that these four new definitions are not well developed, rather they are provisional and should it be decided they should remain, they could be worked up.

@robbiemorrison
Copy link
Contributor Author

That finishes my suggestions. I had though I could submit multiple PRs but it seems that just one outstanding PR is possible. In which case, I would not have named it "mandatory copy-edits".

@robbiemorrison robbiemorrison changed the title mandatory copy-edits mandatory and suggested copy-edits Oct 31, 2023
@robbiemorrison
Copy link
Contributor Author

Just renamed the PR as indicated above. But I am done in any case.

@rdicosmo
Copy link
Contributor

rdicosmo commented Nov 1, 2023

Thanks @robbiemorrison for these changes. To speed up the process, I cherry picked them, with some changes, in #52, so closing this now.

@rdicosmo rdicosmo closed this Nov 1, 2023
@robbiemorrison
Copy link
Contributor Author

Good luck. And am looking forward to promoting this standard following approval and publication in the areas of open science and transparent public policy analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants