Fix vlfeat CMAKE module path #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucky9-cyou
approved these changes
Jul 20, 2022
Neumann-A
reviewed
Jan 24, 2023
| @@ -1,6 +1,6 @@ | |||
| project(vlfeat) | |||
|
|
|||
| include("${CMAKE_MODULE_PATH}/OptimizeTheiaCompilerFlags.cmake") | |||
| include("${CMAKE_SOURCE_DIR}/cmake/OptimizeTheiaCompilerFlags.cmake") | |||
There was a problem hiding this comment.
Suggested change
| include("${CMAKE_SOURCE_DIR}/cmake/OptimizeTheiaCompilerFlags.cmake") | |
| include(OptimizeTheiaCompilerFlags) |
CMAKE_MODULE_PATH was modified to find that module. CMAKE_SOURCE_DIR is wrong if theia is included via add_subdirectory by a parent project. You either go relativ from CMAKE_CURRENT_SOURCE_DIR or you trust CMAKE_MODULE_PATH being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed fix solves the issue when multiple module paths are found for CMAKE. In this sense,
${CMAKE_SOURCE_DIR}is preferred, as it always points to a unique path.