Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/types): Add jsc.experimental.keepImportAssertions to types #9691

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 30, 2024

@kdy1 kdy1 added this to the Planned milestone Oct 30, 2024
@kdy1 kdy1 self-assigned this Oct 30, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 30, 2024 07:56
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: ba69382

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 merged commit 4b4dcfa into swc-project:main Oct 30, 2024
151 of 152 checks passed
@kdy1 kdy1 deleted the issue-9687 branch October 30, 2024 08:57
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #9691 will degrade performances by 3.54%

Comparing kdy1:issue-9687 (ba69382) with main (4d887d0)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-9687 Change
es/visitor/base-perf/boxing_boxed_clone 2.4 µs 2.5 µs -3.54%

@kdy1 kdy1 modified the milestones: Planned, v1.7.41 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch in types between @swc/types and @swc/core for jsc.experimental.keepImportAssertions
1 participant