feat(es/minifier): mark some builtin functions pure. #6842
Conversation
| member_expr!(DUMMY_SP, console.groupCollapsed), | ||
| member_expr!(DUMMY_SP, console.groupEnd), | ||
| member_expr!(DUMMY_SP, console.info), | ||
| member_expr!(DUMMY_SP, console.log), |
There was a problem hiding this comment.
I'm not sure about console. I often use console.log to debug or capture some variables to make the minifier/mangler not optimize it.
There was a problem hiding this comment.
I used it while debugging the minifier
| if let Callee::Expr(e) = &n.callee { | ||
| // Check for pure_funcs | ||
| if pure_fns.contains(&HashEqIgnoreSpanExprRef(e)) { | ||
| if self.pure_funcs.contains(&HashEqIgnoreSpanExprRef(e)) { |
There was a problem hiding this comment.
Can we use two hashset instead?
I think it will avoid allocations
There was a problem hiding this comment.
One hashset with type Lazy<FxHashSet<HashEqIgnoreSpanExprRef<'static>>>
|
I think I misunderstand the usage of the esbuild's list.
|
|
But still, there are indeed some expressions in the list that are calling without side effects. I need to tweak the list. |
Description:
Originally posted by @kdy1 in #6840 (comment)
BREAKING CHANGE:
Related issue (if exists):
The PR relies on code in #6840.