Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): CLI option --ignore #204

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

3axap4eHko
Copy link
Contributor

Fixes CLI option --ignore does not work #203

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2023

CLA assistant check
All committers have signed the CLA.

@3axap4eHko 3axap4eHko force-pushed the ISSUE-203 branch 2 times, most recently from 880937f to 60a4bd9 Compare March 20, 2023 05:34
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Capability Access +/- Transitive Count Publisher
@swc/[email protected] 0.1.5...0.2.24 filesystem, environment +4/-0 kdy1

🚮 Removed packages: @swc/[email protected]

@leonardoventurini
Copy link

@3axap4eHko I am facing this issue and this fix would really come in handy. Let me know if there is anything I can do to help. I can't see the logs as they are expired. Thanks!

@3axap4eHko
Copy link
Contributor Author

@leonardoventurini I've create the PR a few months ago and there still no comments on it or something, let me ping @kdy1

@devjiwonchoi
Copy link

@3axap4eHko Looks like there's a build failure.

@3axap4eHko
Copy link
Contributor Author

@devjiwonchoi sorry, the logs are expired, I don't remember what was failing

@craigmiller160
Copy link

I also sincerely hope this fix gets merged because this is a truly critical problem that needs to be resolved.

@kdy1
Copy link
Member

kdy1 commented Sep 18, 2023

cc @kwonoj How do you think about this PR?

@kdy1
Copy link
Member

kdy1 commented Sep 18, 2023

To everyone, can you try the new native CLI?

swc-project/swc#3859

@3axap4eHko
Copy link
Contributor Author

To everyone, can you try the new native CLI?

swc-project/swc#3859

do you mean swcx?

@kdy1
Copy link
Member

kdy1 commented Sep 18, 2023

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants