Skip to content

Conversation

@brandonhawi
Copy link

@brandonhawi brandonhawi commented Dec 8, 2025

Add Deprecation Warning to ScoreboardV2

Fixes #596

Problem

ScoreboardV2 returns empty line scores for 2025-26 season games between Oct 22 - Dec 25, 2025 due to an NBA backend API bug with a date-based cutoff.

Solution

Add deprecation warning (following BoxScoreTraditionalV2 pattern) to guide users to ScoreboardV3, which:

  • ✅ Works for ALL dates (including the broken Oct-Dec range)
  • ✅ 100% backward compatible (tested back to 2020-21 season)

Demo

Open In Colab

Click to see the deprecation warning in action and verify ScoreboardV3 works correctly.

Changes

Adds standard library deprecation pattern:

  • Module + class docstrings with Sphinx deprecation directive
  • Runtime DeprecationWarning in __init__ (stacklevel=2)
  • Clear migration example

Before:

scoreboard = ScoreboardV2(game_date='2025-10-22')
# Returns 12 games but 0 line scores ❌

After:

scoreboard = ScoreboardV2(game_date='2025-10-22')
# DeprecationWarning: ...use ScoreboardV3 instead...
# Still returns 0 line scores, but warns user

scoreboard = ScoreboardV3(game_date='2025-10-22')
# Returns 12 games + 24 line scores ✅

Quick Validation

Endpoint Oct 22, 2025 Dec 25, 2025 Dec 26, 2025 2024 Season
V2 0 scores ⚠️ 0 scores ⚠️ ✓ Works ✓ Works
V3 ✓ Works ✓ Works ✓ Works ✓ Works

Finding: Cutoff at exactly Dec 25-26, 2025. V3 has no issues.


Non-breaking change - Existing code works, just shows warning.

Full analysis (optional)

Adds deprecation warning following library's established pattern to guide users toward ScoreboardV3.

ScoreboardV2 returns empty line scores for 2025-26 season games between Oct 22 - Dec 25, 2025 due to NBA backend API bug.

ScoreboardV3 is 100% backward compatible and resolves this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ScoreboardV2 not returning scores for 2025 regular season games?

1 participant