Added RedirectUrl into swagger.go to enable custom redirect URL #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubogdan
requested changes
Nov 25, 2021
|
Just update the changes as mentioned above. |
|
Would you please fix the code and resolve conflicts to go forward with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Currently echo-swagger assumes the Redirect URL used in OAuth2 process flow is at the root. Thus in the case of when Swagger UI is not root, the redirection would not work and result in
404 Not Foundreturned. This PR will enable a new parameter RedirectUrl parameter and can be used along with theEchoWrapHandlerso it can overwritten if necessary.Relation issue
None - new feature
Additional context
If the RedirectURL parameter is not set, it will simply take the existing echo-swagger functions.