Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some module Java 11 friendly - where package javax.xml.bind was remove #12139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s50600822
Copy link

@s50600822 s50600822 commented May 3, 2023

Make some modules Java 11 friendly.
Since Java 17 is LTS, it's quite common for folks to have 11 or 17 as their main while still working on Java 8 interchangeably. Most of the cases it should be compatible, except for a few. Like in these modules where javax.xml.bind... is required. While one could switch versions back to 8 to perform the build, it'd be nice to not have to.

Explicitly declare com.sun.xml.bind:jaxb-api would make it work for both Java 8 and 11+. This is also consistent with what we already have in https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-generator/pom.xml.jenkins#L264

Screenshot 2023-05-03 at 4 21 28 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant