Skip to content

Commit

Permalink
chore: use [email protected] for dev environment (#4428)
Browse files Browse the repository at this point in the history
Refs #4033
  • Loading branch information
char0n authored Oct 30, 2024
1 parent 06ff86b commit 1f90787
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ARG VARIANT="20-bookworm"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:1-${VARIANT}

# Install 20.3.0 version of Node.js using nvm
ARG EXTRA_NODE_VERSION="20.3.0"
# Install 20.18.0 version of Node.js using nvm
ARG EXTRA_NODE_VERSION="20.18.0"
RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"

## install emscripten
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.3.0
20.18.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20.3.0-bookworm
FROM node:20.18.0-bookworm

# use bash as default shell
SHELL ["/bin/bash", "-c"]
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ ApiDOM Playground is available at [https://swagger-api.github.io/apidom/](https:
This is a monorepo for all ApiDOM packages. All the code is written in [TypeScript](https://www.typescriptlang.org/).
All the information necessary for working with monorepo can be found in this [article](https://vladimirgorej.com/blog/things-i-have-learned-maintaining-javascript-monorepo-with-lerna/).

Assuming [prerequisites](#prerequisites) are already installed, [Node.js](https://nodejs.org/) `>=20.3.0` and `npm >=9.6.7`
Assuming [prerequisites](#prerequisites) are already installed, [Node.js](https://nodejs.org/) `>=20.18.0 <21` and `npm >=10.8.2`
are the minimum required versions that this repo runs on, but we recommend using the latest version of Node.js@20.

### Setting up
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"private": true,
"type": "module",
"engines": {
"node": "=20.3.0",
"npm": ">=9.6.7"
"node": "=20.18.0",
"npm": ">=10.8.2"
},
"comments": {
"scripts": {
Expand Down

0 comments on commit 1f90787

Please sign in to comment.