-
Notifications
You must be signed in to change notification settings - Fork 18
django 2, use template views, specify default_config #2
base: master
Are you sure you want to change the base?
Conversation
I didn't provide backward compatibility for django 1.11. Shall I change this? |
…e, also django urlresolver is a much better way)
I will split out the serviceworker implementation in an own package (the django url tag makes the special parameter (PWA_APP_FETCH_URL) superfluous). See: |
Hi @devkral, my apologies for taking so long to get to this. I'll try to get it reviewed within the next week. Thank you for taking the time to make these updates! |
no problem |
I'd like to pull in your django-pwa-batteries work since I think people will mostly want both. Would you be okay adding it to this module? And I'd also like to provide support to Django 1.11+ since that's the current LTS. |
sry, github ate my answer. |
Hello,
I rewrote some of your code for django 2 support and cleaner solutions.
My changes are:
I can seperate the commit request if wished