Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

django 2, use template views, specify default_config #2

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

devkral
Copy link

@devkral devkral commented Dec 23, 2017

Hello,
I rewrote some of your code for django 2 support and cleaner solutions.
My changes are:

  • add django 2 requirement and some fixes
  • use templateviews instead of own implementations (can use context stuff now in serviceworker.js)
  • add content_types
  • update README.md
  • add PWA_APP_FETCH_URL (later for my own serviceworker.js default implementation)
  • add default_config in __init__.py (sometimes required for finding the apps config)
    I can seperate the commit request if wished

@devkral
Copy link
Author

devkral commented Dec 23, 2017

I didn't provide backward compatibility for django 1.11. Shall I change this?

@devkral
Copy link
Author

devkral commented Dec 28, 2017

I will split out the serviceworker implementation in an own package (the django url tag makes the special parameter (PWA_APP_FETCH_URL) superfluous). See:
https://github.com/devkral/django-pwa-batteries

@svvitale
Copy link
Owner

svvitale commented Feb 1, 2018

Hi @devkral, my apologies for taking so long to get to this. I'll try to get it reviewed within the next week. Thank you for taking the time to make these updates!

@devkral
Copy link
Author

devkral commented Feb 1, 2018

no problem

@svvitale
Copy link
Owner

svvitale commented Feb 1, 2018

I'd like to pull in your django-pwa-batteries work since I think people will mostly want both. Would you be okay adding it to this module? And I'd also like to provide support to Django 1.11+ since that's the current LTS.

@devkral
Copy link
Author

devkral commented Feb 5, 2018

sry, github ate my answer.
I am ok with the pwa_battery stuff being pulled in. But be aware it is beta. It needs some tests and most probably bugfixes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants