-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Jodel support (#462) #463
Conversation
Thanks, this looks really good for your first Kotlin code 🙌🏼 Please run |
The formatting seems to be ok now but the test throws an error as the JSON part requires additional mocking which I am unfamiliar with. |
I will have a look 👀 |
|
@all-contributors please add @xyrolaith for code |
I've put up a pull request to add @xyrolaith! 🎉 |
@all-contributors please add @xyrolaith for ideas |
I've put up a pull request to add @xyrolaith! 🎉 |
I have never done any Kotlin programming before so please double check.
Also the invoke function could probably use some extra validations.
Fixes #462