Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify URL before (open, share, copy, etc.) #189

Open
serrq opened this issue Jun 10, 2023 · 7 comments
Open

Modify URL before (open, share, copy, etc.) #189

serrq opened this issue Jun 10, 2023 · 7 comments
Assignees
Labels
feature New feature or request

Comments

@serrq
Copy link

serrq commented Jun 10, 2023

Sometimes we need only of basic URL, not the entire link.

So, even if clearing action is right, we just need to copy the root (basic website like amazon.com).

@svenjacobs
Copy link
Owner

Hello @serrq,

could you please explain step by step what you mean and what you want to achieve?

You send a link like amazon.com/something/123 to Leon and only want amazon.com? Wouldn't it be easier to just type the URL then?

@svenjacobs svenjacobs added the question Further information is requested label Jun 12, 2023
@serrq
Copy link
Author

serrq commented Jun 12, 2023

Not exactly. That’s just one example. I want to edit the URL string to my liking before using it for "copy", "open" or "share".

For the most part we use Leon as a cleaner, but I may need to add characters to the link because I have to go elsewhere.

@svenjacobs
Copy link
Owner

svenjacobs commented Jun 12, 2023

Would it be sufficient for you if Leon places the cleaned text / URL into a text edit field so that you can change it?

@serrq
Copy link
Author

serrq commented Jun 12, 2023

Would it be sufficient for you to place the cleaned text / URL into a text edit field so that you can change it?

Of course this is possible but, isn’t this the place to request new features?

Isn’t it more convenient to edit directly inside Leon?

Since it gets the URL from the sharing hub what reason do I have to move to another app in order to complete the editing?

Okay. We can close this thread if you don’t want to implement it.

@svenjacobs
Copy link
Owner

Of course this is possible but, isn’t this the place to request new features?
Isn’t it more convenient to edit directly inside Leon?

This is what I meant 😁 A text edit field on Leons result screen so that the cleaned text can be edited.

@farOverNinethousand
Copy link

Probably a mix of more "quick actions" and a free text edit field would be the way to go.
Example quick actions (like current "URL decode/encode"):

  • Remove all parameters from URL
  • Replace URL with next match of "URL inside parameter"

Then regarding the parameters:
As we are talking about usability on a mobile device, it would probably be a nice idea to have a similar UI to "postman.com" (an API testing platform). I think a screenshot is more meaningful than words so here we go:
2024-02-03 14_45_27-Example URL Params - URLCleaner Test

As parameters are selected/deselected, the URL is updated live.

I'm using this opportunity to thank you for your work on this project Sven!

@svenjacobs
Copy link
Owner

That's what I actually had in mind for the rewrite 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants