Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the URL text selectable on the main screen #349

Closed
JonathanBaby opened this issue Jan 5, 2024 · 3 comments · Fixed by #352
Closed

Make the URL text selectable on the main screen #349

JonathanBaby opened this issue Jan 5, 2024 · 3 comments · Fixed by #352

Comments

@JonathanBaby
Copy link

JonathanBaby commented Jan 5, 2024

Hello Sven and contributors,

It could be handy to make the URL text selectable on the main screen. In case of no sanitizers available, it would still be possible to select any part of the URL root manually, through the default text selection controls : Text selection with touch control (Material Design Guidelines) (long press + highlight the text to select, using handles).

This would stick to a simple TextView component, but selectable.
This would be a smaller change than #189 which requires to switch to an editable text input field, which would need an EditText component.

My support and thanks for the great work 👍

@svenjacobs
Copy link
Owner

Thanks for the feature request. This was easy to resolve and will be available in the next release.

@svenjacobs
Copy link
Owner

@all-contributors please add @JonathanBaby for ideas

Copy link
Contributor

@svenjacobs

I've put up a pull request to add @JonathanBaby! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants