Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with [email protected] #85

Closed
wants to merge 1 commit into from

Conversation

Joerg-Seitz
Copy link

No description provided.

@Joerg-Seitz Joerg-Seitz marked this pull request as draft December 21, 2023 10:44
@Joerg-Seitz Joerg-Seitz closed this Jan 4, 2024
@simi
Copy link
Collaborator

simi commented Jan 4, 2024

Have you resolved this in any other way @Joerg-Seitz?

@willfish
Copy link

@simi This is working for us https://github.com/trade-tariff/routing-filter/blob/master/lib/routing_filter/adapters/routers/journey.rb

@willfish
Copy link

Sadly the lack of responsiveness here made us self-solve in a fork

@simi
Copy link
Collaborator

simi commented Jan 10, 2024

I'm happy to help you to merge this, it would solve #83 as well. But this project got a little outdated, there is missing CI and so on. Would you mind to help resolving those problems?

@willfish
Copy link

I'm happy to open a PR - I've fixed it for our team already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants