Silently ignore the parent #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nvanoorschot |
timfjord
requested changes
May 30, 2017
| @@ -49,29 +49,28 @@ def store_translations(locale, data, options = {}) | |||
|
|
|||
| def lookup(locale, key, scope = [], options = {}) | |||
| key = normalize_flat_keys(locale, key, scope, options[:separator]) | |||
| result = Translation.locale(locale).lookup(key) | |||
| results = Translation.locale(locale).lookup(key).order(key: :desc) | |||
There was a problem hiding this comment.
Why do we need ordering here?
It will just make query more complicated but I don't see any benefits of using it
| iterator[key] = translation_nested_keys[index + 1] ? {} : translation.value | ||
| iterator[key] | ||
| translation_nested_keys = translation.key.slice(chop_range) | ||
| return {} if translation_nested_keys.nil? |
There was a problem hiding this comment.
Let's use unless translation_nested_keys instead of if translation_nested_keys.nil?
|
👍 for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
First I order the translations so that a parent element would be the last result. This makes sure that when checking the key of the first result it is not parents value that is returned.
In the
build_translation_hash_by_keymethod I simply return an empty Hash when the parent is evaluated.