-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove leading newline from <pre>
contents
#14922
Conversation
🦋 Changeset detectedLatest commit: af3d03e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-svelte-14922-svelte.vercel.app/ this is an automated message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in bugs because in order to have a pre
starting with a newline you need to have two newlines: https://html.spec.whatwg.org/multipage/syntax.html#element-restrictions
This is similar to textarea
, for which we have related logic elsewhere (but not related to this fix).
Isn't this expected (see this comment #14783 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted the test and fixed the tests (the one that was adjusted in runtime-legacy hinted at this)
Alternative to #14783. All we need to do, as far as I can tell, is disregard a
\n
that immediately follows a<pre>
tagFixes #14767
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint