Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: SvelteHTMLElements can be used for creating component wrapper #14162

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

sacrosanctic
Copy link
Contributor

@sacrosanctic sacrosanctic commented Nov 5, 2024

Users are sometimes confused when they can't find HTMLDivAttributes because it simply doesn't exist. This PR lets users know where to find the other types.

Reference

related discord help thread https://discord.com/channels/457912077277855764/1303330319423897600

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 6250591

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14162-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14162

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

documentation/docs/07-misc/03-typescript.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 26d109c into sveltejs:main Nov 6, 2024
9 checks passed
@sacrosanctic sacrosanctic deleted the patch-1 branch November 6, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants