-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update banner images and README #13978
Conversation
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice, I am just wondering how it would look if you made the line width of the svelte logo slightly thicker. I am no designer, but the line could look a bit jagged or dotted on some displays.
Should be fixed, what do you think? |
That definitely made it a lot better, thx |
Why is there both a |
The banner_large versions are higher resolution, I'll delete the lower resolution ones and change the new ones to "banner" |
I made a change so that the banner in the README shows up even if the README is displayed on other sites (eg NPM) |
preview: https://svelte-dev-git-preview-svelte-13978-svelte.vercel.app/ this is an automated message |
|
The Site section has been updated to reflect the changes made during the release of Svelte 5. |
These are nice changes, but I wonder if they're working. When I visit https://github.com/Ocean-OS/svelte/tree/main I get a dead image |
The image URLs will work if the PR is merged, as they use the URLs that the images would be at if they were in this repository, (where the images do not currently exist), so sites like NPM will display the images correctly. |
Shoot, I accidentally deleted the changes... |
That’s the worst, I do it all the time unfortunately, thats why you backup your computer |
Fixes #13952, by updating the banner image, adding dark/light mode in the README, and updating the site section info.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint