Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update banner images and README #13978

Closed
wants to merge 0 commits into from
Closed

Conversation

Ocean-OS
Copy link
Contributor

@Ocean-OS Ocean-OS commented Oct 27, 2024

Fixes #13952, by updating the banner image, adding dark/light mode in the README, and updating the site section info.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 27, 2024

⚠️ No Changeset found

Latest commit: 7f8acb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 27, 2024

pnpm add https://pkg.pr.new/svelte@13978

commit: 742a330

@Ocean-OS Ocean-OS changed the title fix: update banner images, add dark mode detection in README docs: update banner images, add dark mode detection in README Oct 27, 2024
Copy link

@realguse realguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice, I am just wondering how it would look if you made the line width of the svelte logo slightly thicker. I am no designer, but the line could look a bit jagged or dotted on some displays.

@Ocean-OS
Copy link
Contributor Author

Ocean-OS commented Oct 27, 2024

This looks really nice, I am just wondering how it would look if you made the line width of the svelte logo slightly thicker. I am no designer, but the line could look a bit jagged or dotted on some displays.

Should be fixed, what do you think?

@realguse
Copy link

That definitely made it a lot better, thx

@dummdidumm
Copy link
Member

Why is there both a banner and banner_large version? Can't we just use the banner version? Then all references to that img will also be kept stable

@Ocean-OS
Copy link
Contributor Author

The banner_large versions are higher resolution, I'll delete the lower resolution ones and change the new ones to "banner"

@Ocean-OS
Copy link
Contributor Author

Ocean-OS commented Nov 1, 2024

I made a change so that the banner in the README shows up even if the README is displayed on other sites (eg NPM)
This will only work if the PR is merged, as it assumes the banners are available in the main repository (not my fork)

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-13978-svelte.vercel.app/

this is an automated message

@Ocean-OS Ocean-OS changed the title docs: update banner images, add dark mode detection in README docs: update banner images and README Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Playground

pnpm add https://pkg.pr.new/svelte@13978

@Ocean-OS
Copy link
Contributor Author

Ocean-OS commented Nov 6, 2024

The Site section has been updated to reflect the changes made during the release of Svelte 5.

@benmccann
Copy link
Member

These are nice changes, but I wonder if they're working. When I visit https://github.com/Ocean-OS/svelte/tree/main I get a dead image

@Ocean-OS
Copy link
Contributor Author

Ocean-OS commented Nov 9, 2024

These are nice changes, but I wonder if they're working. When I visit https://github.com/Ocean-OS/svelte/tree/main I get a dead image

The image URLs will work if the PR is merged, as they use the URLs that the images would be at if they were in this repository, (where the images do not currently exist), so sites like NPM will display the images correctly.

@Ocean-OS
Copy link
Contributor Author

Shoot, I accidentally deleted the changes...

@realguse
Copy link

realguse commented Dec 26, 2024

That’s the worst, I do it all the time unfortunately, thats why you backup your computer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: update README.md banner
5 participants