Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove leading newline from <pre> contents #14922

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 7, 2025

Alternative to #14783. All we need to do, as far as I can tell, is disregard a \n that immediately follows a <pre> tag

Fixes #14767

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: af3d03e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@14922

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-svelte-14922-svelte.vercel.app/

this is an automated message

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in bugs because in order to have a pre starting with a newline you need to have two newlines: https://html.spec.whatwg.org/multipage/syntax.html#element-restrictions

This is similar to textarea, for which we have related logic elsewhere (but not related to this fix).

@paoloricciuti
Copy link
Member

This will result in bugs because in order to have a pre starting with a newline you need to have two newlines: https://html.spec.whatwg.org/multipage/syntax.html#element-restrictions

This is similar to textarea, for which we have related logic elsewhere (but not related to this fix).

Isn't this expected (see this comment #14783 (comment))

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted the test and fixed the tests (the one that was adjusted in runtime-legacy hinted at this)

@dummdidumm dummdidumm merged commit 7737868 into main Jan 7, 2025
11 checks passed
@dummdidumm dummdidumm deleted the trim-pre-newline branch January 7, 2025 10:06
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal invocation with snippet & action
3 participants