Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Tween work with continuous target changes #14895

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

TheSpeedM
Copy link
Contributor

@TheSpeedM TheSpeedM commented Jan 5, 2025

Description

Fixes #14849 by adjusting when this.#current.v is read in Tween.set, getting the behavior more in line with the (now deprecated) tweened. See the issue for demos illustrating the problem.

I couldn't think of an appropriate test for this. As this is my first PR for Svelte, any help or feedback would be greatly appreciated!

Checks

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 5, 2025

🦋 Changeset detected

Latest commit: 287a3bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TheSpeedM
Copy link
Contributor Author

Should I fix the other issue I am having with Tween (#14897) in this PR or should I create a seperate PR?

Copy link
Contributor

github-actions bot commented Jan 5, 2025

Playground

pnpm add https://pkg.pr.new/svelte@14895

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Makes sense to me, but waiting on @Rich-Harris for another pair of eyes

@Rich-Harris Rich-Harris merged commit a646780 into sveltejs:main Jan 6, 2025
1 check passed
@Rich-Harris
Copy link
Member

thank you!

@github-actions github-actions bot mentioned this pull request Jan 6, 2025
@dummdidumm
Copy link
Member

@TheSpeedM feel free to open a separate PR for #14897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching tweened to Tween produces different behaviour
3 participants