fix: Make Tween work with continuous target changes (#14895)

* Read previous_value at a later stage in Tween.set * Add changeset * tweak --------- Co-authored-by: Rich Harris <[email protected]>
sveltejs · Jan 6, 2025 · a646780 · a646780
1 parent dbdb8cd
commit a646780
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/violet-cows-reply.md b/.changeset/violet-cows-reply.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: make Tween work with continuous target changes
diff --git a/packages/svelte/src/motion/tweened.js b/packages/svelte/src/motion/tweened.js
@@ -230,7 +230,6 @@ export class Tween {
 	set(value, options) {
 		set(this.#target, value);
 
-		let previous_value = this.#current.v;
 		let previous_task = this.#task;
 
 		let started = false;
@@ -254,10 +253,12 @@ export class Tween {
 			if (!started) {
 				started = true;
 
-				fn = interpolate(/** @type {any} */ (previous_value), value);
+				const prev = this.#current.v;
+
+				fn = interpolate(prev, value);
 
 				if (typeof duration === 'function') {
-					duration = duration(/** @type {any} */ (previous_value), value);
+					duration = duration(prev, value);
 				}
 
 				previous_task?.abort();