-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support server-rendering attributes of <svelte:html>
blocks
#13065
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 832131f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13065-svelte.vercel.app/ this is an automated message |
@@ -48,6 +48,7 @@ The `src` directory contains the meat of your project. Everything except `src/ro | |||
- `%sveltekit.assets%` — either [`paths.assets`](configuration#paths), if specified, or a relative path to [`paths.base`](configuration#paths) | |||
- `%sveltekit.nonce%` — a [CSP](configuration#csp) nonce for manually included links and scripts, if used | |||
- `%sveltekit.env.[NAME]%` - this will be replaced at render time with the `[NAME]` environment variable, which must begin with the [`publicPrefix`](configuration#env) (usually `PUBLIC_`). It will fallback to `''` if not matched. | |||
- `%svelte.htmlAttributes%` — the attributes collected from `<svelte:html>` blocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should alphabetize these bullets?
Has it been considered to make it a build-time error rather than a warning if someone tries to use I don't think doing that would be a breaking change. A given component starting to use |
For that to work we'd need to read the source code of every imported component, even the ones in |
Oh, right. How about a runtime error then, rather than the runtime warning this is emitting? I still think this is safer, and I still think it shouldn't be considered a breaking change in Kit - because the real breaking change is a library starting to use this new feature and bumping its Svelte peerdep. |
Per sveltejs/svelte#14397 (comment), I'm actually of the view that we shouldn't add this in any case (sorry) |
Companion to sveltejs/svelte#14397
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.