Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add options for enhance update #13022

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

russ3llc
Copy link

fixes #13020 by adding a line describing the enhance update options.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: bd97c96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13022-svelte.vercel.app/

this is an automated message

@russ3llc
Copy link
Author

I don't know how to get the lint test to pass, or if it's even intended for me, the PR submitter, or the PR reviewer. If I missed some applicable guideline, please do let know. :)

@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label Nov 18, 2024
@eltigerchino
Copy link
Member

Thanks for the PR! I'm not sure if we want to maintain two copies of the update option descriptions or if we should just link to https://svelte.dev/docs/kit/@sveltejs-kit#SubmitFunction (which is not very pretty).

I don't know how to get the lint test to pass, or if it's even intended for me, the PR submitter, or the PR reviewer. If I missed some applicable guideline, please do let know. :)

You need to run pnpm generate:types in the packages/kit directory. It seems like you did it right but the single quotes and double quotes formatting got messed up somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enhance update options to documentation.
3 participants