Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlePageData hook #13014

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

konstantinov90
Copy link

resolves #12940


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Nov 16, 2024

🦋 Changeset detected

Latest commit: 285827d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13014-svelte.vercel.app/

this is an automated message

@konstantinov90
Copy link
Author

@eltigerchino Hi! please advise, what should I do to get this PR merged?

@konstantinov90
Copy link
Author

obviosly it needs some tests, but would that be enough?

@eltigerchino eltigerchino added the needs-decision Not sure if we want to do this yet, also design work needed label Nov 25, 2024
@eltigerchino
Copy link
Member

Hi @konstantinov90 , adding a new feature usually requires some discussion amongst maintainers in the issue before deciding to review / merge the related PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request needs-decision Not sure if we want to do this yet, also design work needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: handlePageData hook
3 participants