Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update README and user guide to use eslint flat format for TS configuration #842

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xiaohk
Copy link

@xiaohk xiaohk commented Aug 18, 2024

This PR updates the TS sections in README and user-guide.md by replacing the legacy eslintrc.* configuration with the eslint flat config eslint.config.js.

Copy link

changeset-bot bot commented Aug 18, 2024

⚠️ No Changeset found

Latest commit: b098c45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

{
files: ['**/*.ts', '**/*.js', '**/*.svelte', '**/*.cjs'],
languageOptions: {
parser: tseslint.parser,
Copy link
Member

@ota-meshi ota-meshi Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

I don't think we need to use tseslint.parser for *.js and *.svelte, I think it makes sense to specify only parserOptions here.

Suggested change
parser: tseslint.parser,

Maybe we need another section that only specifies parser: tseslint.parser. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants