runner: add labels to distinguish OS types #15
Conversation
There was a problem hiding this comment.
https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/blob/main/.github/workflows/ci_unit.yml#L61
ref to here, as the label is a sub set of the runner we wanted, may I know why this change ensure the test running at specific runner?
|
ref to log at https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7490317153/job/20388985460#step:1:2 and https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7490317153/job/20388981956#step:1:2 as currently the label is default or a sub set of instance labels, the github runner random pick up an instance to run the test. Hence I am curious on the reason. |
entrypoint.sh
Outdated
| yum install -y curl jq libicu | ||
| else | ||
| # add ubuntu to the label | ||
| RUNNER_LABEL="ubuntu,${RUNNER_LABEL}" |
There was a problem hiding this comment.
If you specify an array of strings or variables, your workflow will execute on any runner that matches all of the specified runs-on values. For example, here the job will only run on a self-hosted runner that has the labels linux, x64, and gpu:
IMO, when the test cases running in parallel, we will have three instances.
- rhel,self-hosted,linux,x86
- ubuntu, self-hosted,linux,x86 # 22.04
- ubuntu, self-hosted,linux,x86 # 20.04
as our condition as belowing
how does the label work?
There was a problem hiding this comment.
@SamYuan1990 yes, this is going to be interesting. Would you like to make a matrix that way? We don't have ubuntu version tag (22.04 and 20.04 are the same in this sense), but rhel and ubuntu are now in the runner labels.
There was a problem hiding this comment.
IMO, I would like to use instance id to specific an instance for test.
@rootfs , could you please help test instance id can be a validate label or instance id as a hash value which too long for label?
if instance id is too long, we can use a label group as Operator system.
There was a problem hiding this comment.
it is not possible to know the instance id before hand so we cannot use it to set up tests. The instance type is known (e.g. t2.micro). See the attached image.
Signed-off-by: Huamin Chen <[email protected]>
|
here is the label |
|
@SamYuan1990 any feedback? once we have the additional labels, can you refactor the CI? thanks. |
No description provided.