Return iter in get_all_versions #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriqaaq
commented
Jan 22, 2025
| self.values | ||
| .iter() | ||
| .map(|value| (value.value.clone(), value.version, value.ts)) | ||
| .collect() | ||
| .map(move |value| (self.key.as_slice(), &value.value, value.version, value.ts)) |
There was a problem hiding this comment.
Currently returning the key to keep the interface uniform by returning the same IterItem everywhere. Do you think it is required here @gsserge ?
There was a problem hiding this comment.
I don't think key is required here. However, if this operation will participate in merging then we might keep the key to keep the iterators uniform - it's just a slice ref, not a copy. Otherwise let's drop the key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
get_all_versionsAPI to return an iterator. This is useful if a key has a large number of versions