CBOR implementation and HTTP connection engine #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickchomey
reviewed
Oct 9, 2024
| ``` | ||
| Where surrealdb.O is defined below. There is no special advantage in using this other than simplicity/legibility. | ||
| ```go | ||
| type surrealdb.O map[interface{}]interface{} |
There was a problem hiding this comment.
Can I suggest something other than 0? It's very unclear whether it is 0 or O.
There was a problem hiding this comment.
@nickchomey I see what you mean. Maybe something like .Obj?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the HTTP connection engine, complementing the existing WebSocket engine, allowing users to choose their preferred connection type (HTTP or WebSocket) based on their needs.
Additionally, the communication encoding has been switched from JSON to CBOR. This change enables more robust data handling, providing richer type information during communication between the client and SurrealDB. By eliminating the need for the previous smart marshalling/unmarshalling logic, CBOR ensures precise handling of data types, aligning with both user requests and the SurrealDB service responses.
Key Changes
dbinjection and generic constraints for results