Feature/handle live query diff #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phughk
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Left a comment, but would be good to get @timpratim s eyes on this as well. Ex the deserialisation. I am creating a ticket to move it out of gorilla and test. Otherwise I think it's ok, thanks for fixing!
|
@phughk i have fixed like you suggested. Although not sure why the test is failing here on github, being a developer "it worked just fine on my machine" !! |
|
@phughk made the change as requested. Thanks a lot ! |
phughk
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phughk i am pretty sure i have done something horrible in here. guide me please
This PR resolves issue #81