Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord integration #1507

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bodevone
Copy link

@bodevone bodevone commented Dec 12, 2023

Add discord as integration

Closes #1069

TODO:

  • Add Banner and Banner Popup
  • Change descriptions
  • Add documentation
  • Decide with names for icons/logos

@bodevone bodevone marked this pull request as ready for review December 12, 2023 02:38
@idanasulin2706
Copy link
Contributor

Hi @bodevone this is an amazing integration, thanks for this one.
Before reaching to that we are in the middle of refactoring the way we are handling notifications (#1386).
So please make sure first you are aligned with that.
Thanks in advance.

@idanasulin2706
Copy link
Contributor

In the meantime @yanivbh1 could you please help with this "Add Banner and Banner Popup", "Add documentation"?

@bodevone
Copy link
Author

@idanasulinmemphis Thanks for checking out this PR, I'll make sure to integrate with #1386 once it will be merged

@bodevone
Copy link
Author

@idanasulinmemphis I have merged with latest update on buffered notifications from #1386 . Could you review this PR and help out with documentation, banners and descriptions?

@idanasulin2706
Copy link
Contributor

Sure @bodevone we will be on it and update ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications to Discord
2 participants