-
-
Notifications
You must be signed in to change notification settings - Fork 347
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[performance] Don't retry/backoff invalid http requests that will nev…
…er succeed (#609) * add httpguts (ew) * add ValidateRequest err wrapping logic * don't retry on unrecoverable errors * i am very clever
- Loading branch information
1 parent
0f01f72
commit 1cdc163
Showing
8 changed files
with
487 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
GoToSocial | ||
Copyright (C) 2021-2022 GoToSocial Authors [email protected] | ||
This program is free software: you can redistribute it and/or modify | ||
it under the terms of the GNU Affero General Public License as published by | ||
the Free Software Foundation, either version 3 of the License, or | ||
(at your option) any later version. | ||
This program is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU Affero General Public License for more details. | ||
You should have received a copy of the GNU Affero General Public License | ||
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
package httpclient | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
"strings" | ||
|
||
"golang.org/x/net/http/httpguts" | ||
) | ||
|
||
// ValidateRequest performs the same request validation logic found in the default | ||
// net/http.Transport{}.roundTrip() function, but pulls it out into this separate | ||
// function allowing validation errors to be wrapped under a single error type. | ||
func ValidateRequest(r *http.Request) error { | ||
switch { | ||
case r.URL == nil: | ||
return fmt.Errorf("%w: nil url", ErrInvalidRequest) | ||
case r.Header == nil: | ||
return fmt.Errorf("%w: nil header", ErrInvalidRequest) | ||
case r.URL.Host == "": | ||
return fmt.Errorf("%w: empty url host", ErrInvalidRequest) | ||
case r.URL.Scheme != "http" && r.URL.Scheme != "https": | ||
return fmt.Errorf("%w: unsupported protocol %q", ErrInvalidRequest, r.URL.Scheme) | ||
case strings.IndexFunc(r.Method, func(r rune) bool { return !httpguts.IsTokenRune(r) }) != -1: | ||
return fmt.Errorf("%w: invalid method %q", ErrInvalidRequest, r.Method) | ||
} | ||
|
||
for key, values := range r.Header { | ||
// Check field key name is valid | ||
if !httpguts.ValidHeaderFieldName(key) { | ||
return fmt.Errorf("%w: invalid header field name %q", ErrInvalidRequest, key) | ||
} | ||
|
||
// Check each field value is valid | ||
for i := 0; i < len(values); i++ { | ||
if !httpguts.ValidHeaderFieldValue(values[i]) { | ||
return fmt.Errorf("%w: invalid header field value %q", ErrInvalidRequest, values[i]) | ||
} | ||
} | ||
} | ||
|
||
// ps. kim wrote this | ||
|
||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.