This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
Add Conductor and MultiSoundPlayer classes to Sound plugin #73
Open
usdivad
wants to merge
30
commits into
superpowers:master
Choose a base branch
from
usdivad:soundAdditions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…); add play() to MultiSoundPlayer
…tialize params and choose diff transition modes ('toNext' still not working 100%), auto-fill transitionBeats
…ormance, output log options
…ivation and resetting for MultiSoundPlayer
usdivad
changed the title
Sound additions
sound: add Conductor and MultiSoundPlayer classes
Feb 16, 2016
usdivad
changed the title
sound: add Conductor and MultiSoundPlayer classes
Add Conductor and MultiSoundPlayer classes to Sound plugin
Feb 16, 2016
Hi and thanks for the PR! Will try to review it as soon as possible. We're currently focused on getting the redesigned app ready so it might take a little while longer... |
Sounds good and no worries! Looking forward to the new app 😄 |
Resolved conflicts: .gitignore plugins/default/sound/typescriptAPI/Sup.Audio.d.ts.txt plugins/default/sound/typescriptAPI/Sup.Audio.ts.txt plugins/default/sound/typescriptAPI/index.ts
Just updated and tested this branch so that it's compatible with the current master branch! Also, I've created a gist with example usage of the two classes in case that's helpful: https://gist.github.com/usdivad/e2872c702a7a31e3562c15f3e047bb0e |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Conductor and MultiSoundPlayer classes to the Sound plugin, usable via
Sup.Audio.Conductor
andSup.Audio.MultiSoundPlayer
respectively.The Conductor schedules audio based on beats using the Web Audio API's clock, allowing for transitions and events to occur in alignment with the musical rhythm of a phrase or section.
The MultiSoundPlayer wraps around multiple SoundPlayers to allow for an "init-loop-tail" scheme for audio playback.
An example game using the classes (updated 2/2017): http://usdivad.com/runaway-reverie || https://usdivad.itch.io/runaway-reverie
Source code: https://github.com/usdivad/runaway-reverie
^ There are a few glitches here and there, but it gives a good idea of the features and musical possibilities available.
I am definitely open to suggestions regarding functionality as well as how to best integrate this into the Superpowers Game engine. Any feedback would be most welcome!