-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Terraform module to configure Azure Batch easily #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rchretien! Please find some comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the new version of the PR.
Providers' requirements are specified in a separate file called versions.tf
and different outputs are now indicated (i.e. the pool_id
, the login_server
of the container registry, as well as the admin username/password) in the outputs.tf
file.
The corpus of the module is also regrouped in the root folder.
Normally, the module is usable "as such", although one has to provide his own subscription ID as a parameter of the module (I don't how we can circumvent it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module looks very good, thanks @rchretien! Only some details left now.
Co-authored-by: Laurent Sorber <[email protected]>
Co-authored-by: Laurent Sorber <[email protected]>
Co-authored-by: Laurent Sorber <[email protected]>
Co-authored-by: Laurent Sorber <[email protected]>
Co-authored-by: Laurent Sorber <[email protected]>
… autoscale formula.
Thanks @lsorber for your comments and for the review! Here's the new version of the PR. Every suggestion has been accepted. I changed a bit my mind based on your comments and have therefore removed anything related to the creation of a private container registry or to the push of a Docker image from the module definition. The information ( Should I add a README? |
Summary
Terraform module that encapsulates Azure Batch's configuration with Docker-compatible nodes running a custom Docker image hosted on a private registry.
The usage is indicated as comment in the
main.tf
file hosted in the root directory.Future improvement