Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macaroon update fixes #4059

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Macaroon update fixes #4059

merged 2 commits into from
Nov 12, 2024

Conversation

btoews
Copy link
Member

@btoews btoews commented Nov 12, 2024

  • d8752b2 - In CI/non-interactive settings, we were trying to open auth.fly.io URLs. When that failed, we printed a message for the user to open the URL and waited for them to do that. Instead, we should fail the 3p discharge attempt. The print-url-and-wait strategy only makes sense in non-local interactive settings (e.g. SSH).
  • f90145f - When flyctl has some macaroons and an OAuth token, it checks whether it's missing macaroons for any orgs in order to accommodate for the user being added to new orgs. This behavior makes less sense when flyctl's tokens came from an environment variable instead of from the config file. So, we disable it in that case.

@btoews btoews merged commit 3ab4f26 into master Nov 12, 2024
30 checks passed
@btoews btoews deleted the ci-token-fetch branch November 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants