Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a standby machine for LSVD process with mounts #3890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Aug 23, 2024

Change Summary

What and Why:

This adds a special case to fly deploy for LSVD processes (detected by a FLY_LSVD_* environment variable defined in their machine config), to allow creating a standby machine for LSVD groups with mounted volumes.

An upcoming feature will allow an LSVD-enabled machine with a mounted volume to fail over its volume data to a standby machine, and this PR will allow automatically creating such a setup through fly deploy.

How:

  • Add some logic to detect an LSVD process group, and use this to allow creating a standby machine even with a mounted volume configured
  • Add a second mount for this configuration in provisionVolumesOnFirstDeploy

Related to:

#3800


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

Also provision a second volume for the LSVD standby machine on deploy.
@wjordan
Copy link
Contributor Author

wjordan commented Aug 28, 2024

One thing making me hesitate about this change is that as opposed to a created stopped Machine (which has no associated cost), creating a 'standby-volume' in advance adds extra ongoing cost to the standby setup that I'm not sure we want to introduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant