Show errors when BG Health Checks Fail #3828
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into an issue where I was unable to tell if a request failed because my code application code was bad, or it was a platform error. Being able to tell the difference let's users know when to retry deploys or fix their code
context.DeadlineExceeded usually happens when the platform fails to respond to a Get in time. We should retry these errors to smooth over platform issues
This reverts commit cd7a2d0. I want to write some proper retry code in fly-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
When we aren't able to get info about a machine during a health check, we don't change any statuses, we just show 'unchecked'. Showing an error is more useful to the user.
How:
Change "unchecked" to whatever error happened, if applicable.
Related to:
Documentation