Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata filter to flaps list #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rugwirobaker
Copy link
Contributor

No description provided.

Comment on lines 193 to 195
for k, v := range metadata {
params += fmt.Sprintf("metadata.%s=%s", k, v)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't separating out URL parameters with a &. A better approach would be to just use url.Values so it can handle encoding too. Also,it doesn't look like state is even used by any of the callers of List() so you could just remove it.

q := make(url.Values)
for k, v := range metadata {
	q.Set("metadata." + k, v)
}

var getEndpoint = ""
if len(q) > 0 {
	getEndpoint = "?" + q.Encode()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants