Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto detect deno.json for globbed slugs #2852

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 7, 2024

What kind of change does this PR introduce?

Bug fix #2846

What is the current behavior?

import_map is only set if the function is declared in config.toml

What is the new behavior?

Also set import_map for function slugs globbed from local directories.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11721004676

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 59.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/deploy/deploy.go 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11720653408: -0.02%
Covered Lines: 6384
Relevant Lines: 10674

💛 - Coveralls

Copy link
Contributor

@jgoux jgoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sweatybridge sweatybridge merged commit 1becd0f into develop Nov 7, 2024
13 checks passed
@sweatybridge sweatybridge deleted the fix-serve branch November 7, 2024 10:42
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom path mapping for dependencies with deno.json seems to be broken
3 participants