Skip to content

Commit

Permalink
Update CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
lhc70000 authored Jan 9, 2017
1 parent 7b9be24 commit e25555c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,21 @@ If you believe the code structures can be improved, please raise an issue.
- `PlayerCore` should only contain logic that controls playback.
- Window related logic should be in `MainWindowController`.
- `windowDidLoad()`: stuff that should be done once
- `windowDidOpen()`: stuff that should be done every time when window shown, like resetting some UI components
- `windowDidOpen()`: stuff that should be done every time when window shown, like resetting some UI components. Note that window is not necessarily loaded here.
- `windowWillClose()`: release / deinitialize

## How to Contribute

0. **Please open an issue before actually starting doing something** to make sure that there's not someone else working on the same feature.
1. Fork and clone the repository
2. Follow [the guide to build with pre-compiled dylibs in README.md](README.md#use-pre-compiled-dylibs)
3. Open `iina.xcworkspace`.
4. Commit changes, test, push, and submit a pull request.

If you want to build libmpv and other depended dylibs on your own, please refer to [the guide in README.md](README.md#build-with-the-lastest-mpv).

**Tips**
**Pull requests**

- Please set target branch of your pull request to `develop`.
- Please set base branch of your pull request to `develop`.
- If you found `develop` has been updated during your change, remember to do a rebase before opening a pull request.
- Please submit **separate pull requests for different features**.

0 comments on commit e25555c

Please sign in to comment.