Clean up query code #47
Conversation
Codecov ReportBase: 97.63% // Head: 97.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 97.63% 97.58% -0.05%
==========================================
Files 4 4
Lines 211 207 -4
==========================================
- Hits 206 202 -4
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| tap_endpoint = 'http://soar.esac.esa.int/soar-sl-tap/tap' | ||
| payload = SOARClient._construct_payload(query) | ||
| # Need to force requests to not form-encode the paramaters | ||
| payload = '&'.join([f'{key}={val}' for key, val in payload.items()]) |
There was a problem hiding this comment.
Ah, if you need this, doesn't this defeat the purpose of having the payload as a dict? What is form-encoded that should not be form-encoded? I guess the '+'s from the ADQL query, but these could be spaces in the first place (then encoded to '+'s; for example, I have code in which the ADQL query is built by f"SELECT filename FROM v_sc_data_item WHERE (instrument='SPICE') AND (insertion_time>='{date_range_str[0]}') AND (insertion_time<='{date_range_str[1]}')"). Anything else?
There was a problem hiding this comment.
Yeah, unfortunately I think spaces or + characters are form encoded, so neither works. I think this PR is still an improvement though, so thanks for suggesting :)
There was a problem hiding this comment.
I think using urllib.parse.urlencode rather than doing this manually would be a small improvement.
|
Given this has an approval and I think it's an improvement, I'm going to merge - if anyone wants to improve further, please open a new PR 😃 |
As suggested by @ebuchlin in #32 (comment)