mismatch between the Swift function type declarations and the C function type declarations #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion type declarations The write handler in the C API expects a const buffer (which maps to UnsafePointer in Swift) since it shouldn't modify the data it's writing, while the Swift type declaration uses a mutable pointer. This matches the C API's expectation that the write handler won't modify the buffer it's writing. The read handler keeps the mutable pointer since it needs to fill the buffer with data. This type safety is actually helping prevent potential bugs where the write handler might accidentally modify the source buffer, which isn't intended in the FFmpeg API design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The write handler in the C API expects a const buffer (which maps to UnsafePointer in Swift) since it shouldn't modify the data it's writing, while the Swift type declaration uses a mutable pointer.
This matches the C API's expectation that the write handler won't modify the buffer it's writing. The read handler keeps the mutable pointer since it needs to fill the buffer with data. This type safety is actually helping prevent potential bugs where the write handler might accidentally modify the source buffer, which isn't intended in the FFmpeg API design.