[HOLD] Create a set of local models #3453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These models are routable and mutable so the work more like rails defaults unlikethe dry-struct models
|
is this PR ready to go or is it on hold pending discussion? |
|
I thought this was part of what was discussed. |
|
@jcoyne can you move this forward by getting appropriate review and/or buy in? Bring it up in standup if nothing else? |
ndushay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
These models are routable and mutable so they work more like rails defaults unlike the dry-struct models.
This has been extracted from #3323
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact (including writing to shared file systems or interacting with other SDR APIs), run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡
⚡ ⚠ If this change updates the Argo UI, run all integration tests that use Argo and create a PR on the integration test repo to fix anything this change breaks. ⚡