fix(rotate): Handle consensus logs that are not ScheduledChange
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two consensus logs that can trigger a change in the authority set, the
ScheduledChangelog and theForcedChangelog.Previously, we did not handle the cases for the other logs: https://paritytech.github.io/polkadot-sdk/master/src/sp_consensus_grandpa/lib.rs.html#152-194.
In a future PR, we should modify the program to add support for
ForcedChangeconsensus log, as it only supportsScheduledChange. This PR simply parses the consensus logs correctly, skipping logs such asOnDisabled, until aScheduledChangeorForcedChangelog is found.