-
Notifications
You must be signed in to change notification settings - Fork 9
DO NOT MERGE: Debug CI #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ingomueller-net
wants to merge
16
commits into
substrait-io:main
Choose a base branch
from
ingomueller-net:debug-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [substrait-java](https://github.com/substrait-io/substrait-java) from `49b0210` to `33c83dc`. - [Release notes](https://github.com/substrait-io/substrait-java/releases) - [Commits](substrait-io/substrait-java@49b0210...33c83dc) --- updated-dependencies: - dependency-name: substrait-java dependency-version: 33c83dc2babb4114607333d8299eced88e4afa01 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
The only change is the addition of the `Version` field, which is expected given substrait-io/substrait-java#406. Signed-off-by: Ingo Müller <[email protected]>
7edb496 to
fb71c45
Compare
nielspardon
reviewed
Jun 12, 2025
.github/workflows/test.yml
Outdated
|
|
||
| - name: Fetch history and tags of submodules | ||
| # This is needed for `substrait-java` or one of its submodules to determine its version. | ||
| run: git submodule foreach --recursive 'git fetch --unshallow || true' |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens when you add the following after this command?
cd substrait-java/substrait; git describe --tags
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tags seem to be present correctly, see CI log.
Closed
This reverts commit a7fcea0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.