Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused option SMOOTH_GEOMETRY #2427

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove unused option SMOOTH_GEOMETRY #2427

wants to merge 1 commit into from
+0 −18

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

remove unused variable MESH_SMOOTH

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title remove unused variables remove unused option MESH_SMOOTH Jan 20, 2025
@bigfooted bigfooted changed the title remove unused option MESH_SMOOTH Remove unused option MESH_SMOOTH Jan 20, 2025
@bigfooted bigfooted changed the title Remove unused option MESH_SMOOTH Remove unused option SMOOTH_GEOMETRY Jan 20, 2025
pcarruscag
pcarruscag reviewed Jan 21, 2025
View reviewed changes
Common/src/geometry/dual_grid/CPoint.cpp
/*--- For smoothing the numerical grid coordinates ---*/
if (config->GetSmoothNumGrid()) {
Coord_Old.resize(npoint, nDim) = su2double(0.0);
Coord_Sum.resize(npoint, nDim) = su2double(0.0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep going if you really want to remove what is unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarruscag pcarruscag pcarruscag left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigfooted @pcarruscag