Test/service/score #183
Open
Test/service/score #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into test/handler/score
| s: &ScoreService{ | ||
| scoreRepo: &mockScoreRepository{ | ||
| getMaxScores: func(ctx context.Context, userID uuid.UUID) (*model.Score, *model.Score, error) { | ||
| return nil, nil, errors.New("db error") |
Member
There was a problem hiding this comment.
repositoryErrorなのにdbとしているところは気になります。
どうでも良いですが。
KinjiKawaguchi
force-pushed
the
test/service/score
branch
from
98df159 to
f86d8e5
Compare
KinjiKawaguchi
force-pushed
the
test/service/score
branch
from
f86d8e5 to
addc4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク
やったこと
やらないこと
できるようになること（ユーザ目線）
できなくなること（ユーザ目線）
動作確認
その他